Skip to content

K8SPG-724: fix extension reinstall #1228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 23, 2025
Merged

K8SPG-724: fix extension reinstall #1228

merged 6 commits into from
Jul 23, 2025

Conversation

pooknull
Copy link
Contributor

@pooknull pooknull commented Jul 16, 2025 •
edited
Loading

K8SPG-724 Powered by Pull Request Badge

https://perconadev.atlassian.net/browse/K8SPG-724

DESCRIPTION

Problem:
On update of the version field for a custom extension, operator uninstalls the old version but doesn't install the new version.

Solution:
Change the order of operations in the install-extensions.sh script: first uninstall the extension, then install the new one.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PG version?
  • Does the change support oldest and newest supported Kubernetes version?

hors
hors reviewed Jul 17, 2025
View reviewed changes
Copy link
Collaborator

@hors hors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pooknull we have updated this test under https://github.com/percona/percona-postgresql-operator/tree/K8SPG-624 please create PR based on this branch

@pooknull pooknull marked this pull request as ready for review July 22, 2025 08:48
@JNKPercona
Copy link
Collaborator

Test Name Result Time
backup-enable-disable passed 00:05:15
custom-extensions passed 00:13:56
custom-tls passed 00:05:32
database-init-sql passed 00:03:12
demand-backup passed 00:27:16
finalizers passed 00:03:39
init-deploy passed 00:03:03
monitoring passed 00:07:59
monitoring-pmm3 passed 00:07:42
one-pod passed 00:05:17
operator-self-healing passed 00:07:53
pgvector-extension passed 00:02:46
pitr passed 00:11:28
scaling passed 00:04:46
scheduled-backup passed 00:28:41
self-healing passed 00:08:25
sidecars passed 00:02:28
start-from-backup passed 00:11:14
tablespaces passed 00:07:52
telemetry-transfer passed 00:03:34
upgrade-consistency passed 00:09:19
upgrade-minor passed 00:06:13
users passed 00:03:57
We run 23 out of 23 03:11:38

commit: aecfc11
image: perconalab/percona-postgresql-operator:PR-1228-aecfc11bf

@hors hors merged commit 71fae20 into main Jul 23, 2025
18 checks passed
@hors hors deleted the K8SPG-724 branch July 23, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hors hors hors left review comments

@egegunes egegunes egegunes approved these changes

@gkech gkech gkech approved these changes

@jvpasinatto jvpasinatto Awaiting requested review from jvpasinatto jvpasinatto is a code owner

@eleo007 eleo007 Awaiting requested review from eleo007 eleo007 is a code owner

@valmiranogueira valmiranogueira Awaiting requested review from valmiranogueira valmiranogueira is a code owner

@nmarukovich nmarukovich Awaiting requested review from nmarukovich nmarukovich is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pooknull @JNKPercona @hors @egegunes @gkech